Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AndroidDriver.js #497

Merged
merged 4 commits into from
Jan 8, 2018
Merged

Update AndroidDriver.js #497

merged 4 commits into from
Jan 8, 2018

Conversation

Crash--
Copy link
Contributor

@Crash-- Crash-- commented Jan 8, 2018

Fix an issue when the filter doesn't exist.

Also added a verbose log with ADB attached devices since it's pretty difficult to debug on CI pipeline.

Crash-- added 2 commits January 8, 2018 17:32
@Crash--
Update AndroidDriver.js
9ec0e5e 
- name doesn't exist 
- Log current attached devices
@Crash--
Update AndroidDriver.js
419ace3
@rotemmiz
Copy link
Member

rotemmiz commented Jan 8, 2018

Great addition, i believe this should be log.error, not log.verbose though

@Crash--
Copy link
Contributor Author

Crash-- commented Jan 8, 2018 •
edited
Loading

Done :)

@rotemmiz
Copy link
Member

rotemmiz commented Jan 8, 2018

Sorry for the nag, but actually the whole string can be a part of the error string. It will have better readability, surely on CI

@rotemmiz rotemmiz merged commit 12df788 into wix:master Jan 8, 2018
@rotemmiz
Copy link
Member

rotemmiz commented Jan 8, 2018

Thanks!

@wix wix locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Crash-- @rotemmiz